Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly forward number of methods to the originals in Compact / Readable wrappers #35

Merged
merged 8 commits into from
Aug 5, 2024
Merged

Correctly forward number of methods to the originals in Compact / Readable wrappers #35

merged 8 commits into from
Aug 5, 2024

Commits on Jul 28, 2024

  1. Correctly forward deserialize_i128 / deserialize_u128 to the original… 

    … deserializer in Compact / Readable wrappers

For historical reasons Deserializer trait has default implementation for 128-bit integers
which returns error, so it is important to not forgot to re-implement those methods.
    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d39e74a View commit details
    Browse the repository at this point in the history

  2. Correctly forward serialize_i128 / serialize_u128 to the original ser… 

    …ializer in Compact / Readable wrappers

For historical reasons Serializer trait has default implementation for 128-bit integers
which returns error, so it is important to not forgot to re-implement those methods.
    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    c758d36 View commit details
    Browse the repository at this point in the history

  3. Correctly forward visit_i128 / visit_u128 to the original visitor in … 

    …Compact / Readable wrappers
    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    82f2796 View commit details
    Browse the repository at this point in the history

  4. Correctly wrap key in SerializeMap::serialize_entry 

    Fixes serde-rs#34
    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    1320028 View commit details
    Browse the repository at this point in the history

  5. Correctly wrap deserializer for deserialize_in_place method

    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d63de9e View commit details
    Browse the repository at this point in the history

  6. Correctly forward Serializer::collect_seq and collect_map methods

    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    dbb1fa9 View commit details
    Browse the repository at this point in the history

  7. Correctly forward skip_field and collect_str to the originals

    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    d281193 View commit details
    Browse the repository at this point in the history

  8. Correctly forward __private_visit_untagged_option to the original wit… 

    …h wrapped deserializer

Although this is private serde API, not forwarding it would be error.
Unfortunately, another private API, Deserializer::__deserialize_content,
cannot be implemented because it accepts private type from serde
    @Mingun
    Mingun committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    ac836f7 View commit details
    Browse the repository at this point in the history