Exhaustive internally tagged tests + support of internally tagged enums in non self-describing formats #2569
Commits on Oct 22, 2024
-
Explain code in ContentDeserializer::deserialize_newtype_struct and a…
…dd comments about coverage
-
-
-
Remove confusing call to deserialize_untagged_variant in deserialize_…
…internally_tagged_variant deserialize_untagged_variant in that place is called when deserialzie_with attribute is set. In that case it performs special actions that is better to use explicitly in deserialize_untagged_variant for readability
-
Consistently use visit_content_seq and visit_content_map when deseria…
…lize enums Helper methods visit_content_[seq|map] does the same as [Seq|Map]Deserializer::deserialize_any and used everywhere except here. Reuse them for consistency
-
Deserializer should not check correctness of data, this is the respon…
…sibility of the Visitor Examples of errors produced during deserialization of internally tagged enums in tests if instead of a Seq/Map a Str("unexpected string") will be provided: In tests/test_annotations.rs flatten::enum_::internally_tagged::tuple: before: `invalid type: string "unexpected string", expected tuple variant` after : `invalid type: string "unexpected string", expected tuple variant Enum::Tuple` flatten::enum_::internally_tagged::struct_from_map: before: `invalid type: string "unexpected string", expected struct variant` after : `invalid type: string "unexpected string", expected struct variant Enum::Struct` -
Store deserializer in Enum[Ref]Deserializer and Variant[Ref]Deseriali…
…zer directly That is cheap, creating a Content[Ref]Deserializer is a no-op
-
-
-
Add support for internally tagged enums in non self-describing formats
Deserializer methods are only hints which deserializer is not obliged to follow. Both TaggedContentVisitor and InternallyTaggedUnitVisitor accepts only visit_map and visit_seq and that is what derived implementation of Deserialize does for structs. Therefore it is fine to call deserialize_map here, as that already did in derived deserialize implementation
-
Add support for struct variants in untagged and adjacently tagged enu…
…ms in non self-describing formats Visitor passed to the deserialize_any supports only visit_map method, so we can always request deserialize_map
-
Use deserialize_unit instead of deserialize_any for unit variants of …
…untagged and adjacently tagged enums
