Support streaming large JSON arrays and objects #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm new to this whole Open Source thing and this is my first pull request so please let me know if there's anything I need to do (or did wrong) @dtolnay |
|
Is anyone looking into this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #526 . It implements
ArrayDeserializerandObjectDeserializerAPIs and allows for arbitrary nesting. The internals are a bit complex due to the way error handling works. Also, in case an actual error happens, maybe one could think about just making every successive call to the deserializer also return errors (i.e. move it into a Failed state)? I am not sure about that part of the design yet. It is also somewhat adjacent to #70It uses lifetimes to ensure only one nested deserializer can be used at a time.
Fixes #404