chore: cleanup nix! #10199
Merged
chore: cleanup nix! #10199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some nix comments explaining it a bit more, cleaned up the nix flake file a bit. Added make targets for nix to simplify stuff and then finally setup caching!
|
PR checklist:
If you're unsure about any of this, please see: |
Fixed the check tests, so osemgrep tests actually run, fixed flags.sh to hopefully fix the builds for non nix targets, and fix the shell target
semgrep-compare-github-8d5c6 resultsRan benchmark on 38 repositories The number of findings differs for 1 repos Whole benchmark is 5.8% slower (a bit of noise is expected) Relative speed improvement is 0.98 on average
Relative memory improvement is 1.00 on average |
ajbt200128
force-pushed
the
austin/cleanup-nix
branch
from
2f5781a
to
c724b3c
Compare
kopecs
reviewed
May 9, 2024
kopecs
approved these changes
May 9, 2024
ajbt200128
force-pushed
the
austin/cleanup-nix
branch
from
2360d16
to
f174213
Compare
aryx
reviewed
May 10, 2024
|
|
||
| # Build targets | ||
| nix-osemgrep: | ||
| nix build ".?submodules=1#osemgrep" |
There was a problem hiding this comment.
what is this magic .?submodules thing?
Merged
ajbt200128
added a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some comments explaining more things, cleaned up the flake a bit, fixed flags.sh to actually fix the nix flake, then setup caching!
Test plan
# with nix installed make nix-check make shell make coreCI step "build-test-nix" passes