fix(integrations): Use payload instead of re-reading closed Body #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreas-marschke
force-pushed
the
fix-integration-json-parsing
branch
from
89c5c26
to
0a837c9
Compare
tboerger
approved these changes
May 2, 2024
andreas-marschke
force-pushed
the
fix-integration-json-parsing
branch
from
0a837c9
to
27e9fb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
r.Bodywas already consumed at the start of the Handler, the Body nil'ed on extraction.This change carries the payload through to extraction to extract values correctly.
Also with this MR, the UI presents the fact that a Task was started by Integration through the TaskLogView.