Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new type secret in Survey Variable #1598

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sparsick
Copy link

Sometimes you want to add a password etc. and hide their value. Therefore, I add a new type 'secret' so this input field will hide the typed value is hidden.

Relates to #904

@sparsick sparsick mentioned this pull request Oct 27, 2023
@sparsick
Copy link
Author

@fiftin Is this PR okay, or should I do more so that it can be merged?

@joseangel-piqueras
Copy link

I need this feature! 💯

@tothakos-code
Copy link

This feature could be misleading. It just hides the input and doesn't handling the actual value as a secret thus someone password will be saved in clear text. The value is easily readable inside the browsers network tab.

My improvement idea:

  • The secret survey "key:value" pairs would be sent to the backend in a different key than "environment" thus it will be separated.
  • Handling the secrets on the backend only need to differ from environments in one place: not saving them to the db.
  • This will break the rerun function, because there will be missing variables, so secret survey fields should always be empty and required for a rerun.

I didn't look into how hard it is to implement this idea or if it's even possible. I might later this week, when i have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants