Fix base URI not included in generated OpenID Connect URLs (#1524) #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
HI @fiftin it would be great if you can review this, it is a relatively simple change but OIDC + sub-path on the URL does not work without it. Thanks. |
tboerger
approved these changes
Feb 5, 2024
|
Since these changes have been approved, could this PR be merged, soon? Currently, using OpenID-Connect with |
|
Any movement on this PR? I'd like to call out the documentation suggests doing this for those who run reverse proxies. https://docs.semui.co/administration-guide/configuration#public-url After two days of OIDC troubleshooting, coming across this was a relief. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenID Connect login does not work when the base URI includes a path component. This PR fixes this.