Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding condition to unmount only components that already not in the Document object. #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vitalii-onopriienko
Copy link

Adding condition to unmount only components that already not in the Document object.

This will resolve issue when after execution  app.unmount() on page all components that have return functions are unmounted (deleted from app cache and all events and event listeners for them are removed) but after app.mount() nothing happening (all stayed exactly alike after unmount).

With new changes after app.unmunt() we are unmounting only components that already not in Document object. So in case when after we changed our document by removing some of components and adding new ones by js we safely able to run app.unmount() and app.mount(). In this case, only already removed components will be unmounted and new one will be mounted.

@carolirod
Copy link

Please merge! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants