Include output from instrumentation process in error messages #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelogomez
force-pushed
the
instrumentationprocess
branch
2 times, most recently
from
1e14262
to
6b828a4
Compare
…comes unreachable
marcelogomez
force-pushed
the
instrumentationprocess
branch
from
6b828a4
to
11c55d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to get the output from the instrumentation process whenever there's a crash or the app has been killed by the OS. Whenever something like this happened we would end up timing out a request and never really know what the issue was. With this we at least know that the process crashes and can use the output from the process to debug further. Note that there are no attempts made to interpret the output.