Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attentive Doc Updates for Action Destinations #7288

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

wtnelso
Copy link
Contributor

@wtnelso wtnelso commented Dec 4, 2024

Proposed changes

Merge timing

Related issues (optional)

@wtnelso wtnelso requested a review from a team as a code owner December 4, 2024 20:57
@wtnelso wtnelso requested a review from forstisabella December 4, 2024 20:57
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@wtnelso wtnelso changed the title Attentive Attentive Doc Updates for Action Destinations Dec 4, 2024
@forstisabella
Copy link
Contributor

hi @wtnelso - is this for a new Attentive (Actions) destination, or are you adding Actions to an existing documentation?

cc: @tcgilbert

@wtnelso
Copy link
Contributor Author

wtnelso commented Dec 5, 2024

Hi @forstisabella, i'm adding to existing documentation, but this is the first time we're rolling out action destinations.

@forstisabella
Copy link
Contributor

Hi @forstisabella, i'm adding to existing documentation, but this is the first time we're rolling out action destinations.

Okay great! if you're rolling out an Actions destination for the first time, you'll need to create a new folder named actions-attentive in the src/connections/destinations/catalog folder and add the content included in this PR to an index.md file.

@wtnelso
Copy link
Contributor Author

wtnelso commented Dec 5, 2024

Hi @forstisabella I just made the requested updates and committed those changes.

@wtnelso
Copy link
Contributor Author

wtnelso commented Dec 9, 2024

Hi @tcgilbert I made the requested updates, I think, could you please review?

Copy link
Contributor Author

@wtnelso wtnelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes made.

@forstisabella forstisabella merged commit 09b7416 into segmentio:develop Dec 10, 2024
4 checks passed
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants