[FUNK-1550] IP Allowlisting Changes #7244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaibhav-nanda
force-pushed
the
FUNK-1550/func-ip-allowlist
branch
from
8315f1d to
0ba13e5
Compare
✅ Deploy Preview for segment-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
forstisabella
previously approved these changes
Nov 21, 2024
src/connections/functions/index.md
Outdated
| #### IP Allowlisting for functions | ||
|
|
||
| With IP Allowlisting, users can ensure that outbound traffic from Functions will originate only from a predefined set of IP addresses. This provides added security for external services by making it easier to recognize and allowlist trusted traffic sources. |
There was a problem hiding this comment.
Suggested change
| With IP Allowlisting, users can ensure that outbound traffic from Functions will originate only from a predefined set of IP addresses. This provides added security for external services by making it easier to recognize and allowlist trusted traffic sources. | |
| > warning " " | |
| > IP Allowlisting is only available for customers on Business Tier plans. | |
| IP Allowlisting uses a NAT gateway to route outbound Functions traffic from Segment’s servers to your destinations through a limited range of IP addresses, which can prevent malicious actors from establishing TCP and UDP connections with your integrations. |
There was a problem hiding this comment.
The warning IP Allowlisting is only available for customers on Business Tier plans has been added as a simple text as it is being displayed as simple text in Destinations IP Allowlisting doc as well.
Ref: https://segment.com/docs/connections/destinations/#ip-allowlisting
src/connections/functions/index.md
Outdated
| To learn more, visit the [Functions Copilot documentation](/docs/connections/functions/copilot/). | ||
|
|
||
| #### IP Allowlisting for functions |
There was a problem hiding this comment.
Suggested change
| #### IP Allowlisting for functions | |
| #### IP Allowlisting |
src/connections/functions/index.md
Outdated
| With IP Allowlisting, users can ensure that outbound traffic from Functions will originate only from a predefined set of IP addresses. This provides added security for external services by making it easier to recognize and allowlist trusted traffic sources. | ||
|
|
||
| To learn more, visit [IP Allowlisting documentation](/docs/connections/destinations/#ip-allowlisting). |
There was a problem hiding this comment.
Should we remove the note in the Destination Overview page that mentions Destination Functions are not supported?
Suggested change
| To learn more, visit [IP Allowlisting documentation](/docs/connections/destinations/#ip-allowlisting). | |
| To learn more, visit [Segment's IP Allowlisting documentation](/docs/connections/destinations/#ip-allowlisting). |
forstisabella
approved these changes
Dec 4, 2024
|
Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
https://segment.atlassian.net/browse/FUNK-1550
The changes are to handle the Functions IP Allowlisting changes made.
Merge timing
Related issues (optional)