-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-Out Mode with No Enabled Destinations #7164
base: develop
Are you sure you want to change the base?
Conversation
@prigiattiperrut cc. @forstisabella, this is a bit tricky: This doesn't apply to just one scenario (opt-out), this applies to all scenario where there should be at least one enabled destination connected to a source. But then this gets complicated with combinations of unmapped destinations and other consent categories. Let's think about how to do this. |
just remembered we are going to be adding another table to this doc when engg finishes one other defect in the wrapper. The new table can be seen here: https://docs.google.com/document/d/1o8XQ-9N6nBxR2XjNIrTPs6y6gZRnzU_38r3CNfo2esw/edit?tab=t.0#bookmark=id.lqel9qezsfmm and covers |
Are we still holding off on this one, or can we merge it now? |
@forstisabella can you review this table and see how we could incorporate it in our onetrust wrapper doc now that the code fix has been deployed. |
@atitsh - I sure can! In the meantime, should we close this PR or merge it? |
close (not merge), we can leave it open as a reminder. |
Proposed changes
I've added a note explaining what to expect when opt-out mode is used with a source that’s not connected to enabled destinations
Merge timing
ASAP once approved
Related issues (optional)
JIRA: https://segment.atlassian.net/browse/LIBRARIES-2179