Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt-Out Mode with No Enabled Destinations #7164

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

prigiattiperrut
Copy link
Contributor

Proposed changes

I've added a note explaining what to expect when opt-out mode is used with a source that’s not connected to enabled destinations

Merge timing

ASAP once approved

Related issues (optional)

JIRA: https://segment.atlassian.net/browse/LIBRARIES-2179

@prigiattiperrut prigiattiperrut requested a review from a team as a code owner October 23, 2024 12:36
@prigiattiperrut prigiattiperrut requested a review from pwseg October 23, 2024 12:36
@atitsh
Copy link
Contributor

atitsh commented Oct 23, 2024

@prigiattiperrut cc. @forstisabella, this is a bit tricky:

This doesn't apply to just one scenario (opt-out), this applies to all scenario where there should be at least one enabled destination connected to a source. But then this gets complicated with combinations of unmapped destinations and other consent categories.

Let's think about how to do this.

@atitsh
Copy link
Contributor

atitsh commented Oct 23, 2024

just remembered we are going to be adding another table to this doc when engg finishes one other defect in the wrapper.

The new table can be seen here: https://docs.google.com/document/d/1o8XQ-9N6nBxR2XjNIrTPs6y6gZRnzU_38r3CNfo2esw/edit?tab=t.0#bookmark=id.lqel9qezsfmm and covers

@pwseg
Copy link
Contributor

pwseg commented Nov 14, 2024

@atitsh @prigiattiperrut

just remembered we are going to be adding another table to this doc when engg finishes one other defect in the wrapper.

The new table can be seen here: https://docs.google.com/document/d/1o8XQ-9N6nBxR2XjNIrTPs6y6gZRnzU_38r3CNfo2esw/edit?tab=t.0#bookmark=id.lqel9qezsfmm and covers

Are we still holding off on this one, or can we merge it now?

@atitsh
Copy link
Contributor

atitsh commented Nov 15, 2024

@forstisabella can you review this table and see how we could incorporate it in our onetrust wrapper doc now that the code fix has been deployed.

@forstisabella
Copy link
Contributor

@forstisabella can you review this table and see how we could incorporate it in our onetrust wrapper doc now that the code fix has been deployed.

@atitsh - I sure can! In the meantime, should we close this PR or merge it?

@atitsh
Copy link
Contributor

atitsh commented Nov 15, 2024

close (not merge), we can leave it open as a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants