Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unify FAQ on Removing Traits from User Profiles #7143

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Add Unify FAQ on Removing Traits from User Profiles #7143

merged 8 commits into from
Dec 18, 2024
+33 −10

Conversation

muhammadatifjav
Copy link
Contributor

Proposed changes

Add FAQ about nullifying trait values in Engage

Merge timing

  • ASAP once approved

Related issues (optional)

https://segment.atlassian.net/browse/KCS-1525

@muhammadatifjav muhammadatifjav marked this pull request as draft October 28, 2024 07:00
@muhammadatifjav
Update faqs.md
aced868 
reverting change
@muhammadatifjav
Update faqs.md
a575491 
Added the Faq to unify section and added some clarity
@muhammadatifjav muhammadatifjav marked this pull request as ready for review October 28, 2024 07:14
stayseesong
stayseesong requested changes Nov 4, 2024
View reviewed changes
src/unify/faqs.md Outdated Show resolved Hide resolved
src/unify/faqs.md Outdated Show resolved Hide resolved
stayseesong
stayseesong requested changes Nov 4, 2024
View reviewed changes
src/unify/faqs.md Outdated Show resolved Hide resolved
@seg-atlantis-prod

This comment has been minimized.

Sign in to view
@seg-atlantis-prod

This comment has been minimized.

Sign in to view
@seg-atlantis-prod
Copy link

Plan Error

running git clone --branch develop --single-branch https://github.com/segmentio/segment-docs.git /home/atlantis/.atlantis/repos/segmentio/segment-docs/7143/default: Cloning into '/home/atlantis/.atlantis/repos/segmentio/segment-docs/7143/default'...
fatal: write error: No space left on device
fatal: fetch-pack: invalid index-pack output
: exit status 128

@pwseg pwseg changed the title Add faqs about null values Add Unify FAQ on Removing Traits from User Profiles Nov 18, 2024
@pwseg pwseg added the content-update updates to content that are not new features, includes grammar fixes, added notes label Nov 18, 2024
@stayseesong stayseesong merged commit b32ca64 into develop Dec 18, 2024
4 of 5 checks passed
@stayseesong stayseesong deleted the engage-faqs-null branch December 18, 2024 23:31
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwseg pwseg pwseg approved these changes

@stayseesong stayseesong stayseesong approved these changes

Assignees
No one assigned
Labels
content-update updates to content that are not new features, includes grammar fixes, added notes KCS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhammadatifjav @stayseesong @pwseg