Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading the segment-source-resource with google ads compatible segm… #14

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

upgrading the segment-source-resource with google ads compatible segm… #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a2309a
upgrading the segment-source-resource with google ads compatible segm…
psankaranarayana Mar 1, 2022
fa54e1d
changes to log level
psankaranarayana Mar 15, 2022
d8d8d8f
bumping version
psankaranarayana Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ __pycache__
.git
.cache
.pypirc
.idea
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pydash
gevent
python-dateutil
segment_source==0.17.0
segment_source==0.17.1
structlog
pytest
pytest-runner
2 changes: 1 addition & 1 deletion segment_source_resource/log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def std_processor(_, method_name, event_dict):

def configure(levelname, **global_values):
try:
level = structlog.stdlib.INFO
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using logging is nice but curious why we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was deprecated

level = logging.INFO
if levelname:
level = structlog.stdlib._NAME_TO_LEVEL[levelname]
except KeyError:
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
setup(
name='segment_source_resource',
packages=['segment_source_resource'],
version='0.16.0',
version='0.16.2',
description='Abstraction to make sources easier to write',
author='Segment',
author_email='[email protected]',
Expand All @@ -12,7 +12,7 @@
'pydash',
'gevent',
'python-dateutil',
'segment_source==0.17.0',
'segment_source==0.17.1',
'structlog',
],
tests_require=['pytest'],
Expand Down