all: replace segmentio/events with segmentio/log #143
Conversation
The latter uses the new log/slog standard in Go. While we are at it replace deprecated uses of io/ioutil.
| @@ -1,3 +1,4 @@ | |||
| //go:build go1.12 | |||
| // +build go1.12 | |||
There was a problem hiding this comment.
Does this obviate line 2, or is it somehow a different thing?
There was a problem hiding this comment.
Ah, GitHub Copilot to the rescue.
Warning
I wonder if we can get rid of the older-style directive... I guess it would break if one of our client applications is still building with Go version less than 1.17.
There was a problem hiding this comment.
Precisely
There was a problem hiding this comment.
I'm not sure I've seen anything as old as 1.17, but probably better safe than sorry
| @@ -206,7 +206,7 @@ func (l *dbLimiter) refreshWriterLimits(ctx context.Context) error { | |||
| if err != nil { | |||
| return errors.Wrap(err, "adjust found rate limit") | |||
| } | |||
| events.Debug("adjusted %v limit from %v/%v to %v/%v", writerName, maxRowsPerMinute, time.Minute, adjustedRate, l.defaultWriterLimit.Period) | |||
| log.EventDebug("adjusted %v limit from %v/%v to %v/%v", writerName, maxRowsPerMinute, time.Minute, adjustedRate, l.defaultWriterLimit.Period) | |||
There was a problem hiding this comment.
Why are some events.Debug changed to log.Debug and some log.EventDebug?
There was a problem hiding this comment.
@janderson-seg : Hmm, I don't see any log.Debug lines, can you point one out please?
There was a problem hiding this comment.
Lines 117 and 209 show an example of this. The source call was events.Debug and on line 117 log.Debug was used and on line 209 log.EventDebug was used.
|
Moving this to new internal repo |
The latter uses the new log/slog standard in Go. While we are at it replace deprecated uses of io/ioutil.