Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored operatingMode related code. #328

Merged
merged 12 commits into from
Apr 18, 2024
Merged

Refactored operatingMode related code. #328

merged 12 commits into from
Apr 18, 2024

Conversation

bsneed
Copy link
Contributor

@bsneed bsneed commented Apr 17, 2024 •
edited
Loading

  • Factored out completion group code to its own class.
  • Fixed downstream issues where completion() could not be called and/or group not left.
  • Updated flush(completion) caller.
  • Fixed linux tests.
  • Updated flush(completion) tests.
  • Added workaround for painfully slow iOS test runner.

@bsneed bsneed changed the title Testing opmode changes Refactored operatingMode related code. Apr 18, 2024
@bsneed bsneed merged commit 01d39d2 into main Apr 18, 2024
8 of 9 checks passed
@bsneed bsneed deleted the bsneed/flushTests branch April 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsneed @alanjcharles