fix: compare default apiHost with apiHost configuration instead of writeKey
#314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alanjcharles @bsneed tagging you as most recent contributors. We are trying to migrate to analytics-swift from the legacy objc version and this is something we would need fixed. Please have a look. |
bsneed
approved these changes
Mar 21, 2024
|
Thanks for finding that @pietropizzi ! We'll get this merged shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just found this bug that when I override the
apiHostthrough the configuration it is set back to the default host once the settings are fetched. Event though the settings don't have an overridden host.That is because you compare the
hostagainstconfiguration.values.writeKeyinstead ofconfiguration.values.apiHost.This fixes that.