Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to using a single date formatter and update unit tests. #285

Merged

Conversation

cprince-foreflight
Copy link
Contributor

@cprince-foreflight cprince-foreflight commented Dec 14, 2023

#284

As described in the ticket above, the two date formatters in the library didn't match up in the strings they produce. I've consolidated to a single date formatter using the string format like:
"2023-12-14T16:03:14.300Z"

The format used by the other date formatter, that I've removed, was:
"2023-12-13T23:26:37.091+0000"

Testing

  • Changed a unit test to support this single date formatter.
  • Did some initial testing in our own app by bringing the changed analytics-swift package in and looking at Segment debugger output for dates with Codable and non-Codable interfaces. Both now are the same in my tests.

@cprince-foreflight cprince-foreflight marked this pull request as ready for review December 14, 2023 18:05
@bsneed bsneed merged commit cc4e0e3 into segmentio:main Dec 14, 2023
1 of 7 checks passed
@bsneed
Copy link
Contributor

bsneed commented Dec 15, 2023

Released as 1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants