Add Experimental Windows Support #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brianmichel
force-pushed
the
brian/add-windows-support
branch
from
d8ea938 to
a136212
Compare
|
@bsneed this should be ready for review if you'd like |
remove merge conflict label
remove merge conflict label
remove merge conflict label
remove merge conflict label
|
Closing this in lieu of the merged/updated PR #348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should build (but not completely test) on Windows. I would label it as experimental since it does run, but will likely have issues that need to be ironed out. As mentioned in #279 a pluggable networking stack will help us work around the problems with
URLSessionbut I figured I'd post this as a mergable artifact.Changes
.editorconfigso that style can be kept consistent across those who are using Xcode and other editors (I don't know if theseis the right settings, but I tried to match what was there)WindowsVendorSystemwith system calls to populate various bits of information where possible.#ifblocks around the codebase to allow for building on WindowsI apologize for the trimming of the whitespace, I can try to rebuild this PR if it's an annoyance, but it seems that VS Code trims whitespace by default and this is where I ended up.