Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flush policies #256

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Update Flush policies #256

merged 4 commits into from
Oct 4, 2023

Conversation

niallzato
Copy link
Contributor

Default visibility of init method will be internal, add public prefix.

Also add test for the interval policy.

@niallzato niallzato requested a review from alanjcharles October 4, 2023 12:46
alanjcharles
alanjcharles approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@alanjcharles alanjcharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work dawg!

@alanjcharles alanjcharles merged commit 1d090a0 into main Oct 4, 2023
7 checks passed
@alanjcharles alanjcharles deleted the niall/flush_policy_test branch October 4, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanjcharles alanjcharles alanjcharles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niallzato @alanjcharles