add getProfile API #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f6fe98 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mericsson
reviewed
Oct 2, 2023
| } | ||
|
|
||
| async function getProfileFromSegment(segment: Segment, userId: string) { |
There was a problem hiding this comment.
Suggested change
| async function getProfileFromSegment(segment: Segment, userId: string) { | |
| async getProfileFromSegment(segment: Segment, userId: string) { |
equivalent?
There was a problem hiding this comment.
Nah - this is outside of the class (so no one pokes at it)
mericsson
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API to get a user's profile from a request.
It reads the
ajs_user_idcookie from an incoming request, then checks the KV to see if a matching profile already exists. If one doesn't, it will call the profiles API to and cache the profile in the KV.Tested in a cloudflare web worker.