Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New APIs to destination actions and code improvements #2626

Open
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

wtnelso
Copy link
Contributor

@wtnelso wtnelso commented Dec 4, 2024

Added 3 new Attentive APIs to destination actions. Additionally, abstracted the codebase to be more readable and modular for future enhancements.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

wtnelso and others added 30 commits November 6, 2024 10:23
Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts

Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Added default mapping for phone field
@wtnelso wtnelso requested a review from a team as a code owner December 4, 2024 14:33
@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@seg-atlantis-prod
Copy link

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

@seg-atlantis-prod
Copy link

Error parsing command: EOF found when expecting closing quote

@wtnelso wtnelso changed the title Attentive New APIs to destination actions and code improvements Dec 4, 2024
@joe-ayoub-segment joe-ayoub-segment self-assigned this Dec 4, 2024
@joe-ayoub-segment
Copy link
Contributor

Hi @wtnelso thanks - please ping me when you'd like me to rereview.

@wtnelso
Copy link
Contributor Author

wtnelso commented Dec 9, 2024

Hi @joe-ayoub-segment just pushed the commit. This is ready for review.

I also left some questions/comments above in the previous suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants