-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New APIs to destination actions and code improvements #2626
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
…Events/index.ts Co-authored-by: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com>
Added default mapping for phone field
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors |
|
packages/destination-actions/src/destinations/attentive/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/attentive/properties.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/attentive/properties.ts
Outdated
Show resolved
Hide resolved
Hi @wtnelso thanks - please ping me when you'd like me to rereview. |
Hi @joe-ayoub-segment just pushed the commit. This is ready for review. I also left some questions/comments above in the previous suggestions. |
Added 3 new Attentive APIs to destination actions. Additionally, abstracted the codebase to be more readable and modular for future enhancements.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.