Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprig] - New Destination - Sprig #2574

Merged
merged 2 commits into from
Nov 12, 2024
Merged

[Sprig] - New Destination - Sprig #2574

merged 2 commits into from
Nov 12, 2024

Conversation

joe-ayoub-segment
Copy link
Contributor

Raising PR for new Destination on behalf of Partner. Original PR here: #2555

Testing

Unit tests included.

Copy link
Contributor

github-actions bot commented Nov 8, 2024

New required fields detected

Warning

Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Sprig, Settings:apiKey
  • Destination: Sprig, Action:identifyUser, Fields:userId
  • Destination: Sprig, Action:trackEvent, Fields:eventName,timestamp,userId

Add these new fields as optional instead and assume default values in perform or performBatch block.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.43%. Comparing base (718fd6c) to head (13d2cbb).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   79.19%   78.43%   -0.76%     
==========================================
  Files        1259     1017     -242     
  Lines       23485    17819    -5666     
  Branches     4776     3355    -1421     
==========================================
- Hits        18599    13977    -4622     
+ Misses       3758     2720    -1038     
+ Partials     1128     1122       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment joe-ayoub-segment merged commit ec795dd into main Nov 12, 2024
14 of 15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the sprig branch November 12, 2024 11:57
@joe-ayoub-segment
Copy link
Contributor Author

PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants