[Snap Audiences] Add error tracking for create audience #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2565 +/- ##
==========================================
- Coverage 78.40% 78.39% -0.02%
==========================================
Files 1012 1012
Lines 17795 17805 +10
Branches 3354 3354
==========================================
+ Hits 13953 13958 +5
- Misses 2720 2723 +3
- Partials 1122 1124 +2 ☔ View full report in Codecov by Sentry. |
| return { externalId: snapAudienceId } | ||
| } catch (error) { | ||
| // Error response | ||
| await sendToSegment( |
There was a problem hiding this comment.
Looks like the linter might be complaining about error.response.data
joe-ayoub-segment
approved these changes
Nov 5, 2024
|
PR deployed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding error tracking to trouble shoot audience creation per our discussion @joe-ayoub-segment
Testing