Bump LogRocket version & Discuss re-enabling tests

[eanyanwu]

This bumps the LogRocket SDK version used by the corresponding segment browser destination.

I'd also like to get the tests enabled. Unfortunately the commit that disabled them did not clarity which tests were flakey or what the errors are, so i'm hoping to get more clarity on that by opening this PR. @joe-ayoub-segment (i also found this closed pr)
I tried some sleuthing by looking through the CI failures around the time the commit went in, but didn't find anything that seemed relevant.

Testing

N/A

• Added unit tests for new functionality
• Tested end-to-end using the local server
• [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [Segmenters] Tested in the staging environment
• [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

Thanks for the PR @eanyanwu .
It was a while ago and I don't recall the specifics of why the tests were failing. I do remember that it was in the middle of a deploy.
Let's see if CI goes green. I'll also run the tests locally.

[joe-ayoub-segment]

hi @eanyanwu - the tests ran fine for me locally.

As for the failing CI checks:

• You can ignore Snyk - that fails for externally raised PRs
• CI / Browser check is failing due to a size limit for the JS package.

In your PR can you update the browser-destinations' package.json from this:

  "size-limit": [
    {
      "path": "dist/web/*/*.js",
      "limit": "200 KB"
    }

to this please?

  "size-limit": [
    {
      "path": "dist/web/*/*.js",
      "limit": "210 KB"
    }

[seg-atlantis-prod]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod]

Error parsing command: EOF found when expecting closing quote

[eanyanwu]

Thanks for taking a look. I understand how frustrating failing tests unrelated to the code you are working on can be 😅

I have bumped the size limit.
I do have one question for later:
Currently, our destination bundles the LogRocket SDK, but your Readme suggests people load SDKs from a CDN. Which is preferred? I looked at other examples and saw both styles.

[joe-ayoub-segment]

hi @eanyanwu - thank you!

Both approaches are fine. If you load from a CDN it's usually a simple case of adding a couple of lines of code to tell Segment to wait for the file to be loaded.

Best regards,
Joe

[eanyanwu]

Thanks! Looks like the failures are not related 🤔 ?

Do i need to do anything more here?

[eanyanwu]

@joe-ayoub-segment 👀 just checking again to see if i need to do anything to get this merged. Thanks!

[joe-ayoub-segment]

hi @eanyanwu - looks like CI is failing. I'll take a look at it on my local machine now.

[joe-ayoub-segment]

Web tests pass locally

[joe-ayoub-segment]

A unrelated server side test is failing. Should be nothing to do with this PR.

[joe-ayoub-segment]

yarn validate looks good.

[joe-ayoub-segment]

Merging to main to see if tests still break.

[joe-ayoub-segment]

Hi @eanyanwu I merged the code and CI passed - so will deploy this Monday + Tuesday next week.
I'll comment on the PR once this has been completed.

[eze-works]

Wonderful, thank you!

[joe-ayoub-segment]

hi @eanyanwu this PR has been deployed. Please confirm that you are happy with the change.