-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Facebook Conversions] Adding Test Event Code to all mappings. #2516
[Facebook Conversions] Adding Test Event Code to all mappings. #2516
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2516 +/- ##
==========================================
+ Coverage 77.99% 78.01% +0.01%
==========================================
Files 991 991
Lines 17383 17398 +15
Branches 3281 3295 +14
==========================================
+ Hits 13558 13573 +15
Misses 2737 2737
Partials 1088 1088 ☔ View full report in Codecov by Sentry. |
hi @seg-leonelsanches thanks for the PR. hi @brennan - another SA enhancement raised by @seg-leonelsanches . Could someone from the Stratconn team please own reviewing this? |
packages/destination-actions/src/destinations/facebook-conversions-api/fb-capi-properties.ts
Show resolved
Hide resolved
...es/destination-actions/src/destinations/facebook-conversions-api/__tests__/addToCart.test.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Will deploy next Tuesday. No deploys this week due to election. |
Hi @seg-leonelsanches PR deployed |
Customers don't want to set the Test Event Code in Settings for all mapping. Suppose a customer with 10+ mappings: is it a good approach setting a Test Event Code when the intention is to test one mapping?
Testing