Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Facebook Conversions] Adding Test Event Code to all mappings. #2516

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

seg-leonelsanches
Copy link
Contributor

@seg-leonelsanches seg-leonelsanches commented Oct 18, 2024

Customers don't want to set the Test Event Code in Settings for all mapping. Suppose a customer with 10+ mappings: is it a good approach setting a Test Event Code when the intention is to test one mapping?

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.01%. Comparing base (2574714) to head (bc32a01).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2516      +/-   ##
==========================================
+ Coverage   77.99%   78.01%   +0.01%     
==========================================
  Files         991      991              
  Lines       17383    17398      +15     
  Branches     3281     3295      +14     
==========================================
+ Hits        13558    13573      +15     
  Misses       2737     2737              
  Partials     1088     1088              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joe-ayoub-segment
Copy link
Contributor

hi @seg-leonelsanches thanks for the PR.
The code looks good to me, but someone from Stratconn will need to review.
Could you also add a unit test for this please? and also show proof of testing.

hi @brennan - another SA enhancement raised by @seg-leonelsanches . Could someone from the Stratconn team please own reviewing this?

Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! :shipit:

@joe-ayoub-segment
Copy link
Contributor

Will deploy next Tuesday. No deploys this week due to election.

@joe-ayoub-segment joe-ayoub-segment merged commit 5e76015 into main Nov 12, 2024
15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the facebook-conversions-event-tester-in-mapping branch November 12, 2024 10:59
@joe-ayoub-segment
Copy link
Contributor

Hi @seg-leonelsanches PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants