Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity between InputField and GlobalSetting #2505

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

nick-Ag
Copy link
Member

@nick-Ag nick-Ag commented Oct 15, 2024

This PR is the first in a series that will upgrade GlobalSetting (top level settings) to support all of the UI features which have been developed for InputField (standard mapping-editor level fields). This will also apply to the AudienceDestination audienceFields options, which are top-level settings for audience destinations.

The main new UI functionality which will be added to GlobalSetting which it did not previously have is dynamic fields.

Related PRs:

Testing

Testing completed successfully via unit tests and successful build. These are type changes only.

Also tested the yarn types command with a dynamic audience setting and it still correctly works:
Screenshot 2024-10-29 at 3 29 39 PM

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@nick-Ag nick-Ag changed the title [wip don't review] Super input field Feature parity between InputField and GlobalSetting Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.84%. Comparing base (831215d) to head (32e828c).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/scaffold.ts 0.00% 2 Missing ⚠️
packages/cli/src/commands/generate/types.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2505      +/-   ##
==========================================
+ Coverage   78.40%   78.84%   +0.44%     
==========================================
  Files        1044     1065      +21     
  Lines       19897    20436     +539     
  Branches     3964     4065     +101     
==========================================
+ Hits        15600    16113     +513     
+ Misses       3203     3193      -10     
- Partials     1094     1130      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nick-Ag nick-Ag marked this pull request as ready for review October 29, 2024 22:24
@nick-Ag nick-Ag requested a review from a team as a code owner October 29, 2024 22:24
@joe-ayoub-segment
Copy link
Contributor

great that this work is happening @nick-Ag 🥳 🎈 💥 !

@joe-ayoub-segment joe-ayoub-segment merged commit b647b36 into main Nov 18, 2024
14 of 15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the super-input-field branch November 18, 2024 15:40
@joe-ayoub-segment
Copy link
Contributor

hi @nick-Ag PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants