Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Klaviyo Actions] | Added MultiStatus Batch Support on TrackEvent #2498

Merged
merged 23 commits into from
Dec 10, 2024

Conversation

Innovative-GauravKochar
Copy link
Contributor

@Innovative-GauravKochar Innovative-GauravKochar commented Oct 10, 2024

Jira Ticket
This pull request aims to add batch support for the TrackEvent action in Klaviyo(Actions).

Local & Stage Testing Documentation

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Innovative-GauravKochar Innovative-GauravKochar changed the title Added trackEvent Batch Support in Klaviyo [Klaviyo Actions] | Added MultiStatus Batch Support on TrackEvent Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 81.35593% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.60%. Comparing base (bb253f2) to head (6a9a882).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
...tion-actions/src/destinations/klaviyo/functions.ts 79.62% 4 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2498      +/-   ##
==========================================
+ Coverage   78.58%   78.60%   +0.01%     
==========================================
  Files        1030     1030              
  Lines       18184    18240      +56     
  Branches     3431     3442      +11     
==========================================
+ Hits        14290    14337      +47     
- Misses       2752     2755       +3     
- Partials     1142     1148       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review October 11, 2024 13:31
@Innovative-GauravKochar Innovative-GauravKochar requested a review from a team as a code owner October 11, 2024 13:31
Copy link
Contributor

@sayan-das-in sayan-das-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this change. The core MultiStatus logic looks good, however I have left some review comments mostly to refactor and simplify the code as these will be listed as examples for external contributors.

As the changes are related to refactoring, please test it once again via unit tests, local and staging after committing the changes just to be sure it doesn't break anything.

sayan-das-in
sayan-das-in previously approved these changes Oct 21, 2024
Copy link
Contributor

@varadarajan-tw varadarajan-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The errorType should not be set to PAYLOAD_VALIDATION_FAILED in scenarios where the problem is not with the payload. The changes are being made to Braze now. We should also do the change in this PR before we proceed.
cc: @sayan-das-in

varadarajan-tw
varadarajan-tw previously approved these changes Oct 23, 2024
@Innovative-GauravKochar Innovative-GauravKochar marked this pull request as ready for review November 5, 2024 09:53
@joe-ayoub-segment joe-ayoub-segment merged commit bb9512a into main Dec 10, 2024
15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the STRATCONN-4154 branch December 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants