-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsys: Audiences as PETs mapping #2398
Conversation
- Implementing Send Audience as PET action.
- Improving Send Audiences as PET payload to work with the new parameters.
hi @seg-leonelsanches - thanks for raising this PR. Looks like this is for a new Action. Could you complete the form on this page please so that we can properly evaluate if a new Action is the right way to go please? I'm not a Responsys SME so I'd like to loop in @mayur-pitale and @longstoryshort as they were involved with writing the Integration. |
Hi @joe-ayoub-segment. You're welcome. Here's the supporting document: https://segment.atlassian.net/wiki/spaces/~62b2d761d337d0b7d09d6455/pages/2874376194/Responsys+PET+per+Audience+review+form |
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/responsys/sendAudienceAsPet/functions.ts
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2398 +/- ##
==========================================
+ Coverage 77.99% 78.09% +0.10%
==========================================
Files 991 993 +2
Lines 17383 17482 +99
Branches 3281 3297 +16
==========================================
+ Hits 13558 13653 +95
+ Misses 2737 2734 -3
- Partials 1088 1095 +7 ☔ View full report in Codecov by Sentry. |
packages/destination-actions/src/destinations/responsys/index.ts
Outdated
Show resolved
Hide resolved
Discussed with @seg-leonelsanches . Agreed for Leonel that he will fix the refreshToken code, then we'll deploy to Stage. We need proof of testing before this can go to prod. |
…o `settings`, in Responsys.
@joe-ayoub-segment This can be deployed in Stage now. |
New required fields detectedWarning Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production. The following required fields were added in this PR:
Add these new fields as optional instead and assume default values in |
OK thanks @seg-leonelsanches I'll do this now. Will notify when done. |
hi @seg-leonelsanches this is deployed to Staging now ... edit: actually there is an issue. The push command didn't work - I need to go debug it. |
Tested in Responsys successfully through Stage (https://app.segment.build/nick-test/destinations/actions-responsys/sources/personas_nick-test-dev/instances/67216bbb86a7770306d97b08/event-delivery?period=past-day): This can be merged now. |
Thanks @seg-leonelsanches - I'll deploy this to Prod on Tuesday. |
hi @seg-leonelsanches my mistake - we can't deploy this week due to the election. Next scheduled deploy is next Tuesday. |
Hi @seg-leonelsanches PR deployed |
Actions Responsys today tries to work with existing PETs. The problem with this is: there’s no way to automatically modify a PET to include new columns when a corresponding audience is created. The actual endpoints only allow us to create new PETs.
The idea is a new Action that creates a new PET for each new audience before sending records to Responsys, also validating if users are already part of the same Profile List the PET belongs. This approach is already used with our customers successfully, but implemented as a Destination Function.
This implementation also follows the cadence that Responsys expects, with one event at a time, waiting for each API response, instead of parallel Promises.
Testing
Payload suggestion for
/refreshAccessToken
:Payload suggestion for
/sendAudienceAsPet
: