Add drivers into the sqlsource package #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
discussing over here: segment-boneyard/source-postgres#6 (though admittedly this probably would have been the better place to host this discussion :) |
tejasmanohar
reviewed
May 5, 2017
| @@ -34,7 +33,7 @@ Usage: | |||
| [-- <extra-driver-options>...] | |||
| dbsource -h | --help | |||
| dbsource --version | |||
|
|
|||
| $P | |||
There was a problem hiding this comment.
Oh lol xD let me remove that tomorrow morning, a bit late right now where I am!
llexical
commented
May 5, 2017
| @@ -4,9 +4,9 @@ import ( | |||
| "fmt" | |||
| "strings" | |||
|
|
|||
| "github.com/Lilibuth12/sqlsource/domain" | |||
There was a problem hiding this comment.
Need to remove this reference, should be using the sqlsource/domain in this repo.
llexical
commented
May 5, 2017
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/Lilibuth12/sqlsource/domain" |
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/Lilibuth12/sqlsource/domain" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in the mysql and postgres drivers into the sqlsource package so other Go programs can use this library without relying on the commandline interface.
There are 3 pull requests in total for this: