Skip to content

Commit

Permalink
FIX, ADD: kwds catchall for Negation node
Browse files Browse the repository at this point in the history
Passing kwds through a negation (as in the learning case) breaks inference - adding a catchall so that the node can ignore unused inputs
solves IBM#26

May need a better mechanism for handling the abstraction of `traverse_execute` but this should suffice for now.
  • Loading branch information
NaweedAghmad committed Jun 24, 2022
1 parent 780a1ff commit 6a09c6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lnn/symbolic/logic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1312,7 +1312,7 @@ def upward(self, **kwds) -> torch.Tensor:
None, _utils.negate_bounds(self.operand.get_facts(*groundings))
)

def downward(self) -> torch.Tensor:
def downward(self, **kwds) -> torch.Tensor:
if self.propositional:
groundings = {None}
else:
Expand Down

0 comments on commit 6a09c6d

Please sign in to comment.