Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coredao/support locked bitcoin #826

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

LeeNorth
Copy link

@LeeNorth LeeNorth commented Jun 12, 2024

🔘 PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe: This PR provides the API and View to add time-locked Bitcoin addresses and display their balances on the home page

📜 Background

CoreDao has released the self-custody BTC staking function on https://stake.coredao.org/. However, after users stake their BTC to the CLTV script address, they cannot see any balance in Xverse. This PR provides an API to add the script address, allowing users to view the locked Bitcoin and the lock time in Xverse.

Issue Link: #[issue_number]
Context Link (if applicable):

🔄 Changes

  1. Add new API on RPC
  2. Display locked Bitcoin balances on the home page
  3. Implement confirmation modal for locked Bitcoin
  4. Add a view for the locked Bitcoin list
  5. Implement storage for saving information about locked Bitcoin

Impact:

  • Explain the broader impact of these changes.
  • How it improves performance, fixes bugs, adds functionality, etc.
    Test Command: window.XverseProviders.LockedBitcoinProvider.addLockedBitcoin(JSON.stringify({address:'2N77umtu7SaNqxP7i7jJ16QG58eVA7kFAJ7',script:'044cfc4266b17576a9142f1123db7813ea56787ce149b79c117a312fd1ac88ac'})) (Please ensure the address and script originate from the staking transaction sent by the Xverse account)

🖼 Screenshot / 📹 Video

Network $6,641 85 Locked Bitcoin Balance

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

@LeeNorth LeeNorth requested a review from a team as a code owner June 12, 2024 09:12
@LeeNorth LeeNorth requested a review from jordankzf June 12, 2024 09:12
@jordankzf jordankzf removed their request for review August 19, 2024 08:31
teebszet pushed a commit that referenced this pull request Jan 9, 2025
…commended-tag

[ENG-5763] Remove DotSwap Recommended Tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant