Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General code cleanup #183

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from
Draft

General code cleanup #183

wants to merge 17 commits into from

Commits on Feb 6, 2024

  1. Remove this TODO this has been implemented here #178

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a15202c View commit details
    Browse the repository at this point in the history

  2. Implement convenient methods

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0ba3e6b View commit details
    Browse the repository at this point in the history

  3. Use constants for magic strings

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9c4fd9c View commit details
    Browse the repository at this point in the history

  4. Use static imports

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    a5a3379 View commit details
    Browse the repository at this point in the history

  5. Be more intentional

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bb7d131 View commit details
    Browse the repository at this point in the history

  6. Extract gson creation into a bean

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    bc863ff View commit details
    Browse the repository at this point in the history

  7. Be more intentional

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    8cab60d View commit details
    Browse the repository at this point in the history

  8. Embrace more SOLID principles

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    3d22533 View commit details
    Browse the repository at this point in the history

  9. Apply make code-style

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    0434f8b View commit details
    Browse the repository at this point in the history

  10. Introduce an interface for PluginDownloader

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7f96abb View commit details
    Browse the repository at this point in the history

  11. Document and remove a TODO (Created an issue for that: #184

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    446000b View commit details
    Browse the repository at this point in the history

  12. Adapt broken test

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9bde64b View commit details
    Browse the repository at this point in the history

  13. Use step builders instead of lombok builders 

    That way it increases developer experience
    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4219e92 View commit details
    Browse the repository at this point in the history

  14. Use step builders instead of lombok builders 

    That way it increases developer experience
    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    4142a72 View commit details
    Browse the repository at this point in the history

  15. Use constants for magic strings

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    2ffbdf9 View commit details
    Browse the repository at this point in the history

  16. Rename MqttService into MqttPublicationService 

    That way it is more intentional
    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    89a0ad2 View commit details
    Browse the repository at this point in the history

  17. Document and restrict static access when possible

    @sebastienvermeille
    sebastienvermeille committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    7994ecf View commit details
    Browse the repository at this point in the history