Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/plugin api support (beta) #146

Merged
merged 42 commits into from
Dec 31, 2023

Conversation

sebastienvermeille
Copy link
Owner

@sebastienvermeille sebastienvermeille commented Dec 18, 2023

Changes

  • Implement an API to allow developers to extends Rika2Mqtt functionalities with plugins

Note: This is a Beta feature, all classes annotated with @beta might be change from one day to another without any deprecation notice.

It comes with some limitations at this stage which are listed here: #150

I will merge it as this is not breaking anything and play with it over time till it get mature

@probot-autolabeler probot-autolabeler bot added docker Pull requests that update Docker code documentation Improvements or additions to documentation java Pull requests that update Java code labels Dec 18, 2023
Copy link

docs-page bot commented Dec 18, 2023

To view this pull requests documentation preview, visit the following URL:

rika2mqtt.cookiecode.dev/~146

Documentation is deployed and generated using docs.page.

@sebastienvermeille sebastienvermeille self-assigned this Dec 18, 2023
@sebastienvermeille sebastienvermeille changed the title feature/plugin api support feature/plugin api support (beta) Dec 31, 2023
@sebastienvermeille
Copy link
Owner Author

Quality Gate Failed Quality Gate failed

Failed conditions

43.7% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

The code coverage take care of example plugins which is not really relevant here. I will ignore/improve this coverage in the future

Copy link

sonarcloud bot commented Dec 31, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

43.7% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@sebastienvermeille sebastienvermeille marked this pull request as ready for review December 31, 2023 11:19
@sebastienvermeille sebastienvermeille merged commit 4c3185a into master Dec 31, 2023
3 of 4 checks passed
@sebastienvermeille sebastienvermeille deleted the feature/plugin-api-support branch December 31, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD docker Pull requests that update Docker code documentation Improvements or additions to documentation feature java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant