Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step4: add smiles #5

Merged
merged 1 commit into from
Apr 23, 2024
Merged

step4: add smiles #5

merged 1 commit into from
Apr 23, 2024

Conversation

sdzhong
Copy link
Owner

@sdzhong sdzhong commented Apr 16, 2024

No description provided.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 97.82%. Comparing base (5e6f5cc) to head (482e913).

Files Patch % Lines
api/smiles/smiles.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main       #5      +/-   ##
===========================================
- Coverage   100.00%   97.82%   -2.18%     
===========================================
  Files            2        4       +2     
  Lines           38       46       +8     
===========================================
+ Hits            38       45       +7     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdzhong
Copy link
Owner Author

sdzhong commented Apr 18, 2024

Bug codecov/worker#393

The tutorial says, "Notice that we have the two files api/smiles/smiles.py and api/smiles/test_smiles.py in our Impacted Files list."
Expected behavior: I see 2 files, smiles.py and test_smiles.py listed.
Observed behavior: I see only 1 file, smiles.py, listed. The Files Changed includes new file test_smiles.py as created in 4a.
image
image

@sdzhong sdzhong merged commit 33a8101 into main Apr 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant