refix: include equipped items when counting quantities of held items in the shop #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请给出测试用例和测试存档 |
|
saves.zip |
|
就是说这个fix其实只有直接修改存档才会与上一版呈现区别吗？按我理解如果离队脚本书写得当，离队人物身上不应该存在道具。 |
|
关于提交信息的小建议。 首先，提交信息第二行开始开头字母要大写。其次，两个完整句子之间不能用逗号分隔。最后，感谢提交者建议参考之前用过的格式：Thanks to user xxx for reporting the bug. |
liuzhier
force-pushed
the
pr_fix_shop_num_equipped_items
branch
from
e8d1b16
to
d1540bc
Compare
|
感谢PalMusicFan的建议 WGTM; TBR; PLEASE |
liuzhier
force-pushed
the
pr_fix_shop_num_equipped_items
branch
from
d1540bc
to
6ab0a4e
Compare
|
建议使用：Thanks to xxx for reporting the bug. |
liuzhier
force-pushed
the
pr_fix_shop_num_equipped_items
branch
from
6ab0a4e
to
b2999fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue 4176ade. Thanks to @rym1020 for reporting the bug.
很抱歉，上次修复该问题时未进行较全面的测试，导致商店计算现有数量时会把未入队的队员身上的装备也加进去，现已更正。
感谢 rym1020 报告问题。
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
How many dependencies was introduced in this PR? Did the minimal requirement changed, for which platform?
Have you written new tests for your changes?
Have you successfully run it with your changes locally?
Have you tested on following platforms?
I certify that I have the right and agree to submit my contributions under the terms of GNU General Public License, version 3 (or any later version at the choice of the maintainers of the SDLPAL Project) as published by the Free Software Foundation.