Support for automatic uploading to pypi #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@denesb do you have pypi account ? so I can add you as an owner for the package ? |
|
I don't. I can create one if it is as simple as registering to a
website. Send me a link if it is so.
…On Tue, 2019-08-06 at 12:19 -0700, Israel Fruchter wrote:
@denesb do you have pypi account ? so I can add you as an owner for
the package ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "
#9?email_source=notifications\u0026email_token=AAKTFWO3DWPFPIFBBIRY5X3QDHFDBA5CNFSM4IJZOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WF35I#issuecomment-518807029
",
"url": "
#9?email_source=notifications\u0026email_token=AAKTFWO3DWPFPIFBBIRY5X3QDHFDBA5CNFSM4IJZOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WF35I#issuecomment-518807029
",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
|
|
https://pypi.org/account/register/
On Wed, Aug 7, 2019 at 10:06 AM Botond Dénes <[email protected]>
wrote:
… I don't. I can create one if it is as simple as registering to a
website. Send me a link if it is so.
On Tue, 2019-08-06 at 12:19 -0700, Israel Fruchter wrote:
> @denesb do you have pypi account ? so I can add you as an owner for
> the package ?
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> [
> {
> ***@***.***": "http://schema.org",
> ***@***.***": "EmailMessage",
> "potentialAction": {
> ***@***.***": "ViewAction",
> "target": "
>
#9?email_source=notifications\u0026email_token=AAKTFWO3DWPFPIFBBIRY5X3QDHFDBA5CNFSM4IJZOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WF35I#issuecomment-518807029
> ",
> "url": "
>
#9?email_source=notifications\u0026email_token=AAKTFWO3DWPFPIFBBIRY5X3QDHFDBA5CNFSM4IJZOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WF35I#issuecomment-518807029
> ",
> "name": "View Pull Request"
> },
> "description": "View this Pull Request on GitHub",
> "publisher": {
> ***@***.***": "Organization",
> "name": "GitHub",
> "url": "https://github.com"
> }
> }
> ]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9?email_source=notifications&email_token=AACTH42PN4KOSZ56JI3JXA3QDJX5XA5CNFSM4IJZOLXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3XNRCQ#issuecomment-518969482>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACTH47EUUEWK2YPIRGOCWLQDJX5XANCNFSM4IJZOLXA>
.
|
|
Done. Username: bdenes, Email: dns.botond at gmail dot com. |
denesb
reviewed
Aug 7, 2019
README.md
Outdated
| pip install -r requirement-dev.txt | ||
| pre-commit install | ||
|
|
||
| # now each commit you do would fixed by black |
There was a problem hiding this comment.
I don't understand this sentence.
There was a problem hiding this comment.
I was me trying to explain yelp's pre-commit, with small success 😭
I'll remove this line
| description='Scylla SStable Tools', | ||
| packages=['sstable_tools'], | ||
| scripts=['sstable-compressioninfo.py', 'sstable-index.py', 'sstable-statistics.py', 'sstable-summary.py'], | ||
| name="sstable_tools", |
There was a problem hiding this comment.
Are these changes done by some automatic formatter?
There was a problem hiding this comment.
yes,
I was using black
https://github.com/psf/black
it was recently adopted by the Python Foundation
denesb
reviewed
Aug 7, 2019
.pre-commit-config.yaml
Outdated
| # hooks: | ||
| # - id: pylint | ||
| # name: pylint27 | ||
| # language_version: python2.7 |
There was a problem hiding this comment.
Please remove commented code.
There was a problem hiding this comment.
I want to also add pylint, but lint is a bit more work, we could do that later, I'll remove those
|
There seems to be another PR (#8) that also adds a licence. |
|
I'll close #8 ( I was using github tool, that automatically suggest a PR... it's nice but not enough) |
denesb
approved these changes
Aug 7, 2019
|
@denesb when we can configure travis ci, release a version is just tagging on master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
need to push a tag into master and a version would be uploaded to pypi
need to enable travis ci for it to work