Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared_ptr: remove deprecated lw_shared_ptr assignment operator #2456

Conversation

avikivity
Copy link
Member

The assignment operator was deprecated in 8038c13 ("shared_ptr: deprecate lw_shared_ptr operator=(T&&)"), more than a year ago. It is safe to remove it now.

The assignment operator was deprecated in 8038c13 ("shared_ptr:
deprecate lw_shared_ptr operator=(T&&)"), more than a year ago. It
is safe to remove it now.
Copy link
Contributor

@nyh nyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only risk of removing the deprecated constructor and not leaving a "= delete" behind is that a few years from now, someone might be tempted to add such a constructor again and not know the history ;-)

@nyh nyh closed this in 03db01b Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants