core/reactor: don't check AIO block count when they are not needed #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only check for sufficient number of AIO blocks when the linux-aio reactor backend was selected. Otherwise these blocks are not used anyway, but the check might result in failure because it think there aren't sufficient number of AIO blocks available. Fixes: scylladb#2453
nyh
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
I approve this patch because I think it's good enough, but I think that an even better solution would move the code messing with the max aio checking INTO the "linux-aio" reactor backends, so it simply doesn't run with other backends, and you won't need some string comparison to check it in some main configure() function.
|
@denesb can we get that into scylla ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only check for sufficient number of AIO blocks when the linux-aio reactor backend was selected. Otherwise these blocks are not used anyway, but the check might result in failure because it think there aren't sufficient number of AIO blocks available.
Fixes: #2453