sharded.hh: add invoke_on variant for a shard range #2449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomershafir
force-pushed
the
sharded-add-invoke-on-range
branch
6 times, most recently
from
6ce5244
to
29da27b
Compare
avikivity
reviewed
Sep 22, 2024
| @@ -35,6 +35,8 @@ | |||
| #include <boost/iterator/counting_iterator.hpp> | |||
There was a problem hiding this comment.
sharded.hh: add invoke_on variant for a shard range
Missing patch changelog
avikivity
reviewed
Sep 22, 2024
include/seastar/core/sharded.hh
Outdated
| requires std::invocable<Func, Service&, Args...> | ||
| && std::is_same_v<futurize_t<std::invoke_result_t<Func, Service&, internal::sharded_unwrap_t<Args>...>>, future<>> | ||
| future<> | ||
| invoke_on(unsigned begin, unsigned end, smp_submit_to_options options, Func func, Args... args) noexcept; |
There was a problem hiding this comment.
Better: pass a std::ranges::range of shards. Then any subset of the shards can be sent. If you want a contiguous range, use std::views::iota.
tomershafir
force-pushed
the
sharded-add-invoke-on-range
branch
from
29da27b
to
a0f6802
Compare
tomershafir
force-pushed
the
sharded-add-invoke-on-range
branch
5 times, most recently
from
84d1bc9
to
5e046b9
Compare
Add a convenient method to invoke a function on a range of shards, to have better support for the cold control path on more complex compute models like shard groups for different tasks. A workload can benefit from such a model if inter-task cooperation is better when grouping from perf and QoS perspectives, for example. Or a computation requires a only a subset of shards due to internal concurrency limits.
tomershafir
force-pushed
the
sharded-add-invoke-on-range
branch
from
5e046b9
to
8c323e6
Compare
|
@avikivity changed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a convenient method to invoke a function on a range of shards, to have better support for the cold control path on more complex compute models like shard groups for different tasks. A workload can benefit from such a model if inter-task cooperation is better when grouping from perf and QoS perspectives, for example. Or a computation requires a only a subset of shards due to internal concurrency limits.