Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc compile include/warn fixes #2448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Misc compile include/warn fixes #2448

wants to merge 2 commits into from

Conversation

travisdowns
Copy link
Contributor

Fix wrong includes related to SEASTAR_MODULE
Fix "unused result" warnings in gcc

Tests all pass, see changes for details.

@travisdowns
thread_pool: fix includes
2756b9b 
No system headers included if SEASTAR_MODULES was undefined, fix it to
the usual pattern.
@travisdowns travisdowns changed the title Misc compile fixes Misc compile include/warn fixes Sep 20, 2024
tchaikov
tchaikov approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. just two nits.

for posterity, we pass -UNDEBUG when building seastar, so cannot use assert() on the critical pathes.

tests/perf/linux_perf_event.cc Outdated Show resolved Hide resolved
src/core/reactor.cc Outdated Show resolved Hide resolved
@travisdowns
Copy link
Contributor Author

for posterity, we pass -UNDEBUG when building seastar, so cannot use assert() on the critical pathes.

Yes, thanks for the note. I don't think any of the changes here involve a location that would be a performance concern for assert.

@travisdowns
warnings: fix unused result warnings
188baf1 
Fix a few unused result warnings that have popped up in gcc.

In some cases this involves actually checking the return type, mostly
for write(event_fd,...) and in this case it seems that we never
expect any type of failure here (non-zero return code would only
be on eventfd wrap if fd is in blocking mode, invalid arguments).
@tchaikov
Copy link
Contributor

for posterity, we pass -UNDEBUG when building seastar, so cannot use assert() on the critical pathes.

Yes, thanks for the note. I don't think any of the changes here involve a location that would be a performance concern for assert.

ahh, thought that the start_aio_eventfd_loop() one was the loop for reaping the events, i was wrong.

tchaikov
tchaikov approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor

@scylladb/seastar-maint hello maintainers, could you help review/merge this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@travisdowns @tchaikov