build: do not print the default value of --c++-standard in help output #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before this change, the output of `./configure.py --help` looks like:
```
--c++-standard CPP_STANDARD
C++ standard to build with [default: ]
```
because the default value of `--c++-standard` option is an empty string.
printing out its value is not helpful, and could be confusing.
as the actual default value of this option varies depending on the
used compiler, so even if we print out the deduced C++ standard,
it is still confusing. not to mention that argparse does not
differentiate the defaulted value in the returned namespace from
`parse_args()` from the user specified one. so, a simpler approach
is just do not specify the default value.
in this change, we
* do not specify the default value for `--c++-standard`, so its
value would be `None` if not specified
* do not print its default value in the `--help` output
Signed-off-by: Kefu Chai <[email protected]>
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, the output of
./configure.py --helplooks like:because the default value of
--c++-standardoption is an empty string. printing out its value is not helpful, and could be confusing.as the actual default value of this option varies depending on the used compiler, so even if we print out the deduced C++ standard, it is still confusing. not to mention that argparse does not differentiate the defaulted value in the returned namespace from
parse_args()from the user specified one. so, a simpler approach is just do not specify the default value.in this change, we
--c++-standard, so its value would beNoneif not specified--helpoutput