build: s/Sanitizers_COMPILER_OPTIONS/Sanitizers_COMPILE_OPTIONS #2435
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change addresses a regression introduced by ed88919, which renamed the exported CMake variable of `Sanitizers_COMPILER_OPTIONS` to `Sanitizers_COMPILE_OPTIONS`, to be more consistent with the names used by CMake. but it failed to update the top-level `CMakeLists.txt`, which was still using the old name to populate this setting down to .pc. that's why some parent project fails to link with the latest seastar with sanitizers enabled. in this change, we correct the variable name. Signed-off-by: Kefu Chai <[email protected]>
|
see also scylladb/scylladb#20596 for the build failure caused by the regression, which is fixed by this change. |
|
@scylladb/seastar-maint hello maintainers, i'd like to request a review of this change, |
|
@scylladb/seastar-maint hello maintainers, i'd like to request a review of this change, |
|
@scylladb/seastar-maint hello maintainers, i'd like to request a review of this change, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change addresses a regression introduced by ed88919, which renamed the exported CMake variable of
Sanitizers_COMPILER_OPTIONStoSanitizers_COMPILE_OPTIONS, to be more consistent with the names used by CMake. but it failed to update the top-levelCMakeLists.txt, which was still using the old name to populate this setting down to .pc. that's why some parent project fails to link with the latest seastar with sanitizers enabled.in this change, we correct the variable name.