cmake: Depend on libbsd if DPDK depends on it #2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Aug 28, 2024
|
@p12tic hi Povilas, do you plan to continue working on this pull request? |
p12tic
force-pushed
the
fix-build-dpdk
branch
from
ac29fb8
to
528e474
Compare
If libbsd-dev is installed during build time, DPDK will depend on it
without a way to turn this off.
config/meson.build has the following:
libbsd = dependency('libbsd', required: false, method: 'pkg-config')
if libbsd.found()
dpdk_conf.set('RTE_USE_LIBBSD', 1)
endif
And lib/eal/include/rte_string_fns.h contains:
#ifdef RTE_USE_LIBBSD
#include <bsd/string.h>
#else /* no BSD header files, create own */
#define strlcpy(dst, src, size) rte_strlcpy(dst, src, size)
#define strlcat(dst, src, size) rte_strlcat(dst, src, size)
#endif /* RTE_USE_LIBBSD */
#endif /* FREEBSD */
Accordingly the only way to address this inflexibility is to ensure that
dpdk dependencies are appropriately transferred to
INTERFACE_LINK_LIBRARIES of the dpdk library.
Signed-off-by: Povilas Kanapickas <[email protected]>
p12tic
force-pushed
the
fix-build-dpdk
branch
from
528e474
to
55037b3
Compare
|
@tchaikov Sorry for the delay in responding, I was away for a bit. I have applied all your comments, the PR should be ready to go. |
|
@scylladb/seastar-maint hello maintainers, could you help approve for the workflow and probably review this change as well? so we can test this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2411.
If libbsd-dev is installed during build time, DPDK will depend on it without a way to turn this off.
config/meson.build has the following:
And lib/eal/include/rte_string_fns.h contains:
Accordingly the only way to address this inflexibility is to ensure that dpdk dependencies are appropriately transferred to INTERFACE_LINK_LIBRARIES of the dpdk library.