API to get group information and to change file ownership #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Jul 1, 2024
tchaikov
reviewed
Jul 1, 2024
tchaikov
reviewed
Jul 1, 2024
tchaikov
reviewed
Jul 1, 2024
tchaikov
reviewed
Jul 1, 2024
tchaikov
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
nyh
reviewed
Jul 1, 2024
avikivity
reviewed
Jul 4, 2024
avikivity
reviewed
Jul 4, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
2 times, most recently
from
9899bb3
to
25ca367
Compare
tchaikov
reviewed
Jul 11, 2024
tchaikov
reviewed
Jul 11, 2024
tchaikov
reviewed
Jul 11, 2024
tchaikov
reviewed
Jul 11, 2024
tchaikov
reviewed
Jul 27, 2024
tchaikov
reviewed
Jul 27, 2024
tchaikov
reviewed
Jul 27, 2024
tchaikov
reviewed
Jul 27, 2024
tchaikov
reviewed
Jul 27, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
2 times, most recently
from
bbf24d2
to
5424c1d
Compare
rebased instead of merge commit. |
tchaikov
suggested changes
Aug 23, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
5424c1d
to
06e8164
Compare
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
nyh
requested changes
Aug 29, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
06e8164
to
da2ee2e
Compare
|
@muthu90tech when you push a new version and ask for a review, please write a comment saying what you changed from the previous version. |
nyh
requested changes
Sep 3, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
da2ee2e
to
fe2a67c
Compare
muthu90tech
commented
Sep 4, 2024
There was a problem hiding this comment.
changes made:
- Made the ec() method public in seastar/src/core/syscall_result.hh > syscall_result
- Modified the test, to assert on error code as well
- the memset on buf not needed as getgrnam only writes to it.
- removed unnecessary var to hold buffer length.
Commit Sep 15:
@nyh
After reading comments from @avikivity , I have created a separate seastar specific group struct and named it group_details
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
fe2a67c
to
653962d
Compare
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
653962d
to
02e6796
Compare
muthu90tech
commented
Sep 16, 2024
muthu90tech
commented
Sep 16, 2024
avikivity
approved these changes
Sep 16, 2024
muthu90tech
commented
Sep 16, 2024
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
02e6796
to
b47563a
Compare
avikivity
reviewed
Sep 17, 2024
| @@ -61,6 +61,14 @@ struct directory_entry { | |||
| std::optional<directory_entry_type> type; | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
Add APIs to get group details and to change ownership of file.
Please enrich the patch changelog with the details.
There was a problem hiding this comment.
Add APIs to get group details and to change ownership of file.
Please enrich the patch changelog with the details.
Thanks @avikivity , I have added details to the commit log
There are a few calls in scylladb that bypass Seastar APIs when making libc and syscall (getgrnam, chown), see issue scylladb/scylladb#17443. This commit implements those APIs, which can be used to address the issue scylladb/scylladb#17443
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
b47563a
to
6daa5f3
Compare
|
Please drop the artificial merge commit. |
muthu90tech
force-pushed
the
helpers-for-scylla-17443
branch
from
96693f5
to
6daa5f3
Compare
@avikivity , apologies, syncing my fork resulted in this, corrected it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scylladb codebase is bypassing seastar api to make syscalls directly, instead add seastar APIs for those syscall and use it in the transport/controller.cc in scylla
see issue: scylladb/scylladb#17443