shared_token_bucket: resolve FIXME #2308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The specialization of 'struct rovers' for 'capped_release::no' does not support 'release()' member function. If it was called, it would call abort(). This change resolves FIXME that demanded this member function to not be compiled. Usage of '= delete' was introduced to break the compilation if the user tries to use release(). Signed-off-by: Patryk Wrobel <[email protected]>
ptrsmrn
pushed a commit
to ptrsmrn/seastar
that referenced
this pull request
Jul 17, 2024
The specialization of 'struct rovers' for 'capped_release::no' does not support 'release()' member function. If it was called, it would call abort(). This change resolves FIXME that demanded this member function to not be compiled. Usage of '= delete' was introduced to break the compilation if the user tries to use release(). Signed-off-by: Patryk Wrobel <[email protected]> Closes scylladb#2308
lovio
pushed a commit
to lovio/seastar
that referenced
this pull request
Aug 30, 2024
The specialization of 'struct rovers' for 'capped_release::no' does not support 'release()' member function. If it was called, it would call abort(). This change resolves FIXME that demanded this member function to not be compiled. Usage of '= delete' was introduced to break the compilation if the user tries to use release(). Signed-off-by: Patryk Wrobel <[email protected]> Closes scylladb#2308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The specialization of 'struct rovers' for 'capped_release::no'
does not support 'release()' member function. If it was called,
it would call abort().
This change resolves FIXME that demanded this member function
to not be compiled. Usage of '= delete' was introduced to break the
compilation if the user tries to use release().