TINYGL: Remove unimplemented OpenGL 1.2 declarations #5520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquadran
requested changes
Dec 12, 2023
aquadran
reviewed
Dec 12, 2023
| @@ -45,10 +45,12 @@ TGLenum ColorFormatToTGL(eColorDataFormat format) { | |||
| return TGL_RGBA; | |||
| case eColorDataFormat_ALPHA: | |||
| return TGL_ALPHA; | |||
| #if 0 | |||
There was a problem hiding this comment.
I'm not sure about it, all texture modes inside implementations are supported
|
there are few cases in 1.1 which were declared and never implemented. to have header easier to maintain I prefer to keep as it is. it's up to developer to check implementation status for engine. I'm rather agains it doing any changes in header. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it a bit easier to identify where fallbacks might be needed in equivalent OpenGL code, and makes it slighly clearer what TinyGL actually supports.
TGL_BGRandTGL_BGRAwere being used by the HPL1 engine, but my understanding is that TinyGL support there is still incomplete so I just commented the relevant code out.