GRAPHICS: Use custom stream callbacks for loading TTF fonts #5456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccawley2011
force-pushed
the
ttf-stream
branch
from
0c17fdf
to
767fb9b
Compare
ccawley2011
commented
Nov 21, 2023
| _font = _deletableFont; | ||
| BaseFileManager::getEngineInstance()->closeFile(file); |
There was a problem hiding this comment.
This probably isn't correct either.
|
@ccawley2011, any updates? Also, the patch got bitrot badly now. |
The PR is rebased now, but there's still a potential issue with the Wintermute engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces memory usage when loading larger fonts - the ZipArchive class already loads the entire file into memory, so requiring a second block of memory for use with FreeType is an issue when dealing with CJK files which can go up to 8 MB.