TETRAEDGE: Support Android and Switch versions #5021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcoder
force-pushed
the
syb-rb
branch
4 times, most recently
from
e496d61
to
d881e6b
Compare
mgerhardy
reviewed
May 19, 2023
mduggan
reviewed
May 21, 2023
mduggan
reviewed
May 21, 2023
phcoder
force-pushed
the
syb-rb
branch
2 times, most recently
from
8b4adc9
to
5b0eed0
Compare
This allows the languages to be modified after initial detection as a result of e.g. installing language patch
FSNode doesn't work for archives. And we need to use .obb in packed Android version.
Fortunately it's not compressed, so we don't have to keep a copy in memory
This allows ot e.g. detect if Hebrew patch was applied after initial detection
This is a minor tag used on switch but without declaration we error-out. Just skip it for now
|
Nice work! |
bluegr
changed the title
phcoder
changed the title
It doesn't yet. Menu doesn't show up properly and if I bypass the menu, then this version is missing the mouse cursor and hence doesn't show it which breaks the experience |
|
Thanks for the updates! LGTM, I'm happy to merge as long as no other objections to the common code changes. |
|
Could you please try to solve the current conflicts so we can merge it? Thanks! :-) |
|
@phcoder any updates on this? There are a lot of conflicts now, which need to be addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improves iOS detection/support.