Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8.1 experimental style #54

Open
wants to merge 7 commits into
base: 2.8.1-experimental
Choose a base branch
from

Conversation

maggu2810
Copy link

Some styling stuff that could improve readability.

@therealchalz
Copy link

Of note is that a few of these changes are Java 7+ compatible only, such as switching on String values and using the diamond to infer generic types. I'm not sure what the compatibility targets/goals of JSSC are but this could potentially cause issues on embedded devices (and/or anyone using GNU Classpath, other 1.5/1.6-only stuff etc.). A lot of the other changes are nice though.

@maggu2810
Copy link
Author

Yes, I know that some stuff needs Java 7 or higher.

The pom file for the 2.8.1 experimental branch already set 1.7 for source and target:
https://github.com/scream3r/java-simple-serial-connector/blob/2.8.1-experimental/pom.xml#L61

So, the changes are compatible to the current setup.

@woodrowbarlow
Copy link

Just wanted to say that jSSC is currently the only reasonable option for open-source serial port connectivity (since RxTx went dead) for folks on embedded devices with custom chipsets -- many of which are stuck using GNU Classpath which doesn't offer full compliance with Java versions newer than 1.5. To make these changes would leave us in the lurch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants